Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds flag for saving report toml to back build and rebase #1598

Merged

Conversation

joe-kimmel-vmw
Copy link
Contributor

@joe-kimmel-vmw joe-kimmel-vmw commented Jan 11, 2023

Summary

Adds a --report-output-dir flag to both build and rebase commands. If that flag is present then we will write the report.toml file which contains valuable metadata in a friendly format.

Output

Before

this "before" snapshot includes absolutely zero report.toml files:

> pack build ...
> ls
[observe the complete and utter lack of report.toml]

After

> pack build ... --report-output-dir `pwd`
> ls
[gaze upon my report.toml file, ye mighties, and despair! Or rejoice, whatevs really but rejoicing is more fun]

(and similar for rebase)

Documentation

  • Should this change be documented?
    • Yes, see <-- Hey it looks like pack cli flags are auto-documented? So that'll kinda take care of itself after this is released and the docs are regenerated with that version of pack?
    • No

Related

Resolves #1221
Resolves #1565

@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jan 11, 2023
@github-actions github-actions bot added this to the 0.29.0 milestone Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1598 (ac117c3) into main (d1024e9) will decrease coverage by 0.04%.
The diff coverage is 85.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
- Coverage   80.61%   80.58%   -0.03%     
==========================================
  Files         156      156              
  Lines       10455    10480      +25     
==========================================
+ Hits         8427     8444      +17     
- Misses       1528     1534       +6     
- Partials      500      502       +2     
Flag Coverage Δ
os_linux 79.33% <85.46%> (-0.02%) ⬇️
os_macos 77.43% <85.46%> (-0.02%) ⬇️
os_windows 80.49% <85.46%> (-0.02%) ⬇️
unit 80.58% <85.46%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@joe-kimmel-vmw joe-kimmel-vmw force-pushed the 1221-report-toml-for-the-peoples branch from d4c6c3f to 36316cd Compare January 12, 2023 01:50
@joe-kimmel-vmw joe-kimmel-vmw changed the title (wip) manually verified working report toml for build phase (wip) (manually verified) report toml for build phase Jan 12, 2023
@joe-kimmel-vmw joe-kimmel-vmw force-pushed the 1221-report-toml-for-the-peoples branch from eed7f0a to e46cad3 Compare January 12, 2023 22:12
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
@joe-kimmel-vmw joe-kimmel-vmw force-pushed the 1221-report-toml-for-the-peoples branch from e46cad3 to b3d0512 Compare January 12, 2023 22:33
@joe-kimmel-vmw joe-kimmel-vmw changed the title (wip) (manually verified) report toml for build phase adds flag for saving report toml to back build and rebase Jan 12, 2023
Signed-off-by: Joe Kimmel <86852107+joe-kimmel-vmw@users.noreply.github.com>
@joe-kimmel-vmw joe-kimmel-vmw marked this pull request as ready for review January 12, 2023 22:42
@joe-kimmel-vmw joe-kimmel-vmw requested review from a team as code owners January 12, 2023 22:42
@jkutner jkutner merged commit 6c23a08 into buildpacks:main Jan 14, 2023
@joe-kimmel-vmw joe-kimmel-vmw deleted the 1221-report-toml-for-the-peoples branch January 17, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ways to extract docker digest in Pack cli build. pack should export report.toml
2 participants