Bump default lifecycle from 0.15.1 to 0.15.2 #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SaumyaBhushan <saumya@knoldus.com>
Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Signed-off-by: Saumya <76432998+SaumyaBhushan@users.noreply.github.com>
Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Signed-off-by: Saumya <76432998+SaumyaBhushan@users.noreply.github.com>
Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Signed-off-by: Saumya <76432998+SaumyaBhushan@users.noreply.github.com>
Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Signed-off-by: Saumya <76432998+SaumyaBhushan@users.noreply.github.com>
Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Signed-off-by: Saumya <76432998+SaumyaBhushan@users.noreply.github.com>
Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Signed-off-by: Saumya <76432998+SaumyaBhushan@users.noreply.github.com>
Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com> Signed-off-by: Saumya <76432998+SaumyaBhushan@users.noreply.github.com>
Update our Actions to avoid set-output command
github-actions
bot
added
type/chore
This will pick up a small bugfix for builds with image extensions Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
update-lifecycle
branch
from
4cacd47 to
33f0aab
Compare
dfreilich
approved these changes
Dec 4, 2022
| @@ -1866,7 +1866,7 @@ func testBuild(t *testing.T, when spec.G, it spec.S) { | |||
| h.AssertEq(t, args.Daemon, true) | |||
| h.AssertEq(t, args.PullPolicy, image.PullNever) | |||
|
|
|||
| args = fakeImageFetcher.FetchCalls["buildpacksio/lifecycle:0.15.1"] | |||
| args = fakeImageFetcher.FetchCalls[fmt.Sprintf("%s:%s", cfg.DefaultLifecycleImageRepo, builder.DefaultLifecycleVersion)] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will pick up a small bugfix for builds with image extensions
@dfreilich it would be awesome to pull this into 0.28.0. Given the nature of the change, I don't think this requires a new RC, but up to you.