Fix a few bugs #1542
Merged
Fix a few bugs #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/chore
natalieparellano
changed the base branch from
main
to
refactor-lifecycle-execution
|
Blocking on #1539 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
==========================================
- Coverage 81.14% 81.12% -0.02%
==========================================
Files 155 155
Lines 10090 10094 +4
==========================================
+ Hits 8187 8188 +1
- Misses 1420 1422 +2
- Partials 483 484 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dfreilich
force-pushed
the
refactor-lifecycle-execution
branch
from
96eaa06 to
03f4c69
Compare
Fix (restore): when gid is provided, it shouldn't override other flags Fix (analyze): when cache image is used, flags should not also contain -cache-dir Fix (restore): when cache image is used, flags should not also contain -cache-dir - Variable rename (ops for operations) Fix (restore): provide registry credentials when using a cache image Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
fix/few-bugs
branch
from
92a4fb4 to
a675dc3
Compare
github-actions
bot
removed
the
type/chore
sambhav
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a few bugs uncovered during #1539
Documentation
Related
Resolves #___