Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change suggested heroku stack images to the new url #1451

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Jun 8, 2022

Summary

The image names / locations for the CNB-compatible Heroku stack images have changed. heroku/pack:* images still exist, but they won't be updated in the future. heroku/heroku:*-cnb(-build) are published alongside each new release of the heroku stack (heroku/heroku:*). We've done this to hopefully alleviate some of the confusion around our image names.

Output

Before

Stacks maintained by the community:

    Stack ID: heroku-20
    Description: The official Heroku stack based on Ubuntu 20.04
    Maintainer: Heroku
    Build Image: heroku/pack:20-build
    Run Image: heroku/pack:20

After

Stacks maintained by the community:

    Stack ID: heroku-20
    Description: The official Heroku stack based on Ubuntu 20.04
    Maintainer: Heroku
    Build Image: heroku/heroku:20-cnb-build
    Run Image: heroku/heroku:20-cnb

Documentation

  • Should this change be documented?
    • No

Related

Introduction of new image tags: heroku/base-images#213

@joshwlewis joshwlewis requested a review from a team as a code owner June 8, 2022 14:54
@github-actions github-actions bot added this to the 0.27.0 milestone Jun 8, 2022
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jun 8, 2022
@jromero jromero modified the milestones: 0.27.0, 0.28.0 Jun 8, 2022
@jromero
Copy link
Member

jromero commented Jun 8, 2022

@joshwlewis thank you for the update. Do you mind signing the commit as required by our contributing guidelines?

@jromero jromero enabled auto-merge June 8, 2022 15:59
Signed-off-by: Josh W Lewis <josh.lewis@salesforce.com>
auto-merge was automatically disabled June 8, 2022 16:24

Head branch was pushed to by a user without write access

@joshwlewis joshwlewis force-pushed the heroku-stack-image-change branch from c220d3e to f18ae22 Compare June 8, 2022 16:24
@github-actions github-actions bot modified the milestones: 0.28.0, 0.27.0 Jun 8, 2022
@joshwlewis
Copy link
Member Author

@jromero thanks for the review. Sorry I missed the signature (oops!). I've squashed and signed the commit. But that also disabled your auto-merge.

@jromero jromero modified the milestones: 0.27.0, 0.28.0 Jun 9, 2022
@jromero jromero enabled auto-merge June 9, 2022 02:46
@jromero jromero merged commit 2c8e735 into buildpacks:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants