Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow wildcard "any" stack #1234

Merged
merged 2 commits into from
Jul 21, 2021
Merged

Allow wildcard "any" stack #1234

merged 2 commits into from
Jul 21, 2021

Conversation

jkutner
Copy link
Member

@jkutner jkutner commented Jul 20, 2021

Summary

Fixes a bug that prevents * stacks from working.

Output

Before

$ pack build ...
...
ERROR: failed to build: validating stack mixins: buildpack heroku/procfile@0.7.0 does not support stack my_stack
make: *** [test] Error 1

After

$ pack build ...
...
Successfully built image python-cnb-test

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

@jkutner jkutner requested a review from a team as a code owner July 20, 2021 02:42
@github-actions github-actions bot added this to the 0.20.0 milestone Jul 20, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jul 20, 2021
@codecov
Copy link

codecov bot commented Jul 20, 2021 •
edited
Loading

Codecov Report

Merging #1234 (359df6c) into main (5bde87f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   80.95%   80.95%           
=======================================
  Files         138      138           
  Lines        8493     8493           
=======================================
  Hits         6875     6875           
  Misses       1180     1180           
  Partials      438      438
Flag Coverage Δ
os_linux 80.59% <100.00%> (ø)
os_macos 78.11% <100.00%> (ø)
os_windows 80.87% <100.00%> (ø)
unit 80.64% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jkutner jkutner added type/bug Issue that reports an unexpected behaviour. and removed type/enhancement Issue that requests a new feature or improvement. labels Jul 20, 2021
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Jul 21, 2021
@jromero jromero removed the type/enhancement Issue that requests a new feature or improvement. label Jul 21, 2021
@jromero jromero changed the title Fix a bug in resolving mixins that prevents wildcard stacks from working Allow wildcard "any" stack Jul 21, 2021
@jromero jromero merged commit 4c340df into main Jul 21, 2021
@jromero jromero deleted the jkutner/fix-any-stack branch July 21, 2021 02:22
@sambhav sambhav mentioned this pull request Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jromero jromero jromero approved these changes

Assignees
No one assigned
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jkutner @jromero