Disable color when not in terminal #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/enhancement
Codecov Report
@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 80.37% 80.35% -0.01%
==========================================
Files 130 130
Lines 7969 7964 -5
==========================================
- Hits 6404 6399 -5
Misses 1147 1147
Partials 418 418
Flags with carried forward coverage won't be shown. Click here to find out more. |
jromero
reviewed
Feb 9, 2021
jromero
reviewed
Feb 9, 2021
dfreilich
force-pushed
the
no-color-terminal
branch
from
95c3380 to
0443e9e
Compare
* Move IsTerminal to internal logging package, to keep it general but not expose it as part of public API Signed-off-by: David Freilich <dfreilich@vmware.com>
* Change log_writer tests to run sequentially - In a number of tests, we adjust the color settings of the terminal, which adjusts it globally. There are edge cases, therefore, where our adjusting color in one test could adjust it for another test and cause odd failures Signed-off-by: David Freilich <dfreilich@vmware.com>
dfreilich
force-pushed
the
no-color-terminal
branch
from
0443e9e to
b2c3b41
Compare
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Output
Before
After
Documentation
Related
Resolves #486