Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspect remote images built with Platform API 0.5 #1057

Merged
merged 7 commits into from
Mar 4, 2021
Merged

Inspect remote images built with Platform API 0.5 #1057

merged 7 commits into from
Mar 4, 2021

Conversation

dwillist
Copy link
Contributor

@dwillist dwillist commented Feb 4, 2021 •
edited
Loading

Signed-off-by: dwillist dthornton@vmware.com

Summary

  • Add support for running pack inspect-image on remote images.
  • Adds support using the --bom flag without a docker daemon.

Output

Before

  • remote images were not inspected, instead local image info was duplicated.
  • errors fetching local image boms would error when running on a system without docker.

After

  • remote images are inspected!
  • remote image bom can be inspected on systems without a docker daemon

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1034
Requires buildpacks/imgutil#90 to be merged.

@github-actions github-actions bot added this to the 0.17.0 milestone Feb 4, 2021
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Feb 4, 2021
@codecov
Copy link

codecov bot commented Feb 4, 2021 •
edited
Loading

Codecov Report

Merging #1057 (7617732) into main (1e483db) will decrease coverage by 0.06%.
The diff coverage is 85.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   80.41%   80.36%   -0.05%     
==========================================
  Files         133      133              
  Lines        8156     8160       +4     
==========================================
- Hits         6558     6557       -1     
- Misses       1170     1174       +4     
- Partials      428      429       +1
Flag Coverage Δ
os_linux 79.81% <83.34%> (+0.05%) ⬆️
os_macos 77.30% <83.34%> (-0.04%) ⬇️
os_windows 80.27% <85.72%> (-0.05%) ⬇️
unit 79.81% <83.34%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dfreilich dfreilich changed the title fixes needed to correctly inspect remote images Inspect remote images built with Platform API 0.5 Feb 8, 2021
@dfreilich dfreilich added status/blocked Issue or PR that is blocked. See comments. and removed type/chore Issue that requests non-user facing changes. labels Feb 8, 2021
@dfreilich dfreilich modified the milestones: 0.17.0, 0.18.0 Feb 8, 2021
@dfreilich dfreilich removed the status/blocked Issue or PR that is blocked. See comments. label Feb 9, 2021
dfreilich
dfreilich suggested changes Feb 9, 2021
View reviewed changes
acceptance/os/variables_darwin.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
inspect_image.go Outdated Show resolved Hide resolved
@dfreilich dfreilich marked this pull request as ready for review February 10, 2021 07:32
@dfreilich dfreilich requested a review from a team as a code owner February 10, 2021 07:32
@dwillist
fixes needed to correctly inspect remote images
08be825 
Signed-off-by: dwillist <dthornton@vmware.com>
@dwillist
add mockImage wrapper and fix unit tests
ed3d237 
Signed-off-by: dwillist <dthornton@vmware.com>
@dwillist dwillist force-pushed the inspect_image_remote_fix branch from 7fb9761 to ed3d237 Compare February 24, 2021 20:00
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Feb 24, 2021
@dwillist
acceptance test merge conflict changes
a4a6597 
Signed-off-by: dwillist <dthornton@vmware.com>
@dwillist dwillist force-pushed the inspect_image_remote_fix branch from 8537230 to a4a6597 Compare February 25, 2021 02:08
@dwillist dwillist requested a review from dfreilich February 25, 2021 03:18
@dwillist dwillist force-pushed the inspect_image_remote_fix branch from 1c9d37e to 4d65e36 Compare March 3, 2021 00:07
@dwillist
Copy link
Contributor Author

dwillist commented Mar 3, 2021

Recent commits on this branch also address the problems in #1095

@dwillist dwillist mentioned this pull request Mar 3, 2021
Closed
dfreilich
dfreilich approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@dfreilich dfreilich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Just small nit in comment

acceptance/acceptance_test.go Outdated Show resolved Hide resolved
@dfreilich
Update version in test to 0.18.0
ab25287 
Signed-off-by: David Freilich <dfreilich@vmware.com>
@dfreilich dfreilich merged commit edc4657 into main Mar 4, 2021
@dfreilich dfreilich deleted the inspect_image_remote_fix branch March 4, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreilich dfreilich dfreilich approved these changes

Assignees
No one assigned
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

pack inspect-image fails for remote images built with platform API 0.5
2 participants
@dwillist @dfreilich