-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Platform APIs 0.5, 0.6 #1051
Conversation
Signed-off-by: dwillist <dthornton@vmware.com>
Signed-off-by: dwillist <dthornton@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #1051 +/- ##
==========================================
+ Coverage 80.52% 80.97% +0.46%
==========================================
Files 136 136
Lines 6050 8306 +2256
==========================================
+ Hits 4871 6725 +1854
- Misses 751 1156 +405
+ Partials 428 425 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
If there isn't expected to be a lifecycle update with buildpacks/lifecycle#520, should we defer this to the next milestone? |
@dfreilich sounds good 👍 |
Given the release of |
Signed-off-by: dwillist <dthornton@vmware.com>
Ping @dwillist 👋 Is this really ready to merge out are there any outstanding items? |
The conversation happened out of band, but word was it’s “just waiting for reviews” |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great!
Quite a few of the changes were in adding a space before a comment, so there were fewer changes than I expected, and I'm sorry we didn't merge it in earlier!
Summary
implement changes needed to support platform api
0.6
, Need to wait for a lifecycle release with buildpacks/lifecycle#520 to be merged and released before writing acceptance tests.Really this PR just makes the following changes in the codebase: