Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output entire sha in quiet mode #1035

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Output entire sha in quiet mode #1035

merged 2 commits into from
Jan 26, 2021

Conversation

dfreilich
Copy link
Member

Summary

We initially trimmed the sha down to 12 characters. We got a feature request that it output the entire sha here, which makes more sense anyways (if we have the information, we may as well share it), so this changes that to be the full string.

Output

Before

$  pack build test -p ~/workspace/paketo-samples/go/mod/ -q
test@sha256:7c3b2ba175bf

After

$  out/pack build test -p ~/workspace/paketo-samples/go/mod/ -q
test@sha256:7c3b2ba175bf5779f7b3fad1b0a6d0137367c9fe555afe4d227bedebba7ceb90

Documentation

  • Should this change be documented?
    • No

Related

Relates to #285
Relates to #831

* We initially trimmed the sha down to 12 characters. We got a feature request that it output the entire sha, which makes more sense anyways (if we have the information, we may as well share it), so this changes that to be the full string.

Signed-off-by: David Freilich <dfreilich@vmware.com>
@dfreilich dfreilich requested a review from a team as a code owner January 25, 2021 14:39
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Jan 25, 2021
@github-actions github-actions bot added this to the 0.17.0 milestone Jan 25, 2021
@dfreilich dfreilich removed the type/chore Issue that requests non-user facing changes. label Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #1035 (e8ed4ce) into main (29d0954) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   80.23%   80.22%   -0.00%     
==========================================
  Files         130      130              
  Lines        7989     7986       -3     
==========================================
- Hits         6409     6406       -3     
  Misses       1160     1160              
  Partials      420      420              
Flag Coverage Δ
os_linux 79.58% <100.00%> (-<0.01%) ⬇️
os_macos 76.94% <100.00%> (-<0.01%) ⬇️
os_windows 80.13% <100.00%> (-<0.01%) ⬇️
unit 79.58% <100.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

For compatibility reasons, this expands the valid range of values returned by quiet mode.

Signed-off-by: David Freilich <dfreilich@vmware.com>
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Jan 25, 2021
@dfreilich dfreilich merged commit 52c3fe2 into main Jan 26, 2021
@dfreilich dfreilich deleted the output-full-sha-quiet branch January 26, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant