Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asset downloads should be interruptible with ctrl+c #235

Closed
ekcasey opened this issue Jul 10, 2019 · 0 comments · Fixed by #292
Closed

asset downloads should be interruptible with ctrl+c #235

ekcasey opened this issue Jul 10, 2019 · 0 comments · Fixed by #292
Labels
type/bug Issue that reports an unexpected behaviour.
Milestone
0.4.0

Comments

@ekcasey
Copy link
Member

ekcasey commented Jul 10, 2019 •
edited
Loading

pack create-builder

Given pack create-builder is running
When I crtl+c
Then Any asset downloads should be immediately interrupted and the command should exit

pack build

Given pack build --buildpack is running and a buildpack is in the process of downloading
When I crtl+c
Then Any asset downloads should be immediately interrupted and the command should exit
@ekcasey ekcasey added the type/bug Issue that reports an unexpected behaviour. label Jul 10, 2019
@ekcasey ekcasey mentioned this issue Jul 10, 2019
Closed
@ekcasey ekcasey changed the title pack create-builder should be interruptible with ctrl+c asset downloads should be interruptible with ctrl+c Jul 10, 2019
dgageot added a commit to dgageot/pack that referenced this issue Sep 12, 2019
@dgageot
Pass context to Download()
82115c8 
Fixes buildpacks#235

Signed-off-by: David Gageot <david@gageot.net>
dgageot added a commit to dgageot/pack that referenced this issue Sep 12, 2019
@dgageot
Pass context to Download()
fcb626b 
Fixes buildpacks#235

Signed-off-by: David Gageot <david@gageot.net>
@dgageot dgageot mentioned this issue Sep 12, 2019
Merged
dgageot added a commit to dgageot/pack that referenced this issue Sep 12, 2019
@dgageot
Pass context to Download()
83c6b22 
Fixes buildpacks#235

Signed-off-by: David Gageot <david@gageot.net>
@jromero jromero added this to the 0.4.0 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Make Download() interruptible dgageot/pack
2 participants
@jromero @ekcasey