Merge pull request #2151 from sap-contributions/blob-downloader-client

Do not initialize `http.Client` during each request to a remote location

pkg/blob/downloader.go

@@ -28,20 +28,36 @@ type Logger interface {
 	Writer() io.Writer
 }
 
+type DownloaderOption func(d *downloader)
+
+func WithClient(client *http.Client) DownloaderOption {
+	return func(d *downloader) {
+		d.client = client
+	}
+}
+
 type Downloader interface {
 	Download(ctx context.Context, pathOrURI string) (Blob, error)
 }
 
 type downloader struct {
 	logger       Logger
 	baseCacheDir string
+	client       *http.Client
 }
 
-func NewDownloader(logger Logger, baseCacheDir string) Downloader {
-	return &downloader{
+func NewDownloader(logger Logger, baseCacheDir string, opts ...DownloaderOption) Downloader {
+	d := &downloader{
 		logger:       logger,
 		baseCacheDir: baseCacheDir,
+		client:       http.DefaultClient,
 	}
+
+	for _, opt := range opts {
+		opt(d)
+	}
+
+	return d
 }
 
 func (d *downloader) Download(ctx context.Context, pathOrURI string) (Blob, error) {
@@ -146,7 +162,7 @@ func (d *downloader) downloadAsStream(ctx context.Context, uri string, etag stri
 		req.Header.Set("If-None-Match", etag)
 	}
 
-	resp, err := (&http.Client{}).Do(req) //nolint:bodyclose
+	resp, err := d.client.Do(req) //nolint:bodyclose
 	if err != nil {
 		return nil, "", err
 	}