Skip to content

Commit

Permalink
Update Release.md to include pack version constraint pruning
Browse files Browse the repository at this point in the history
Signed-off-by: David Freilich <david.freilich@appsflyer.com>
  • Loading branch information
dfreilich committed Dec 6, 2021
1 parent 1d03717 commit 07dd22f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ The [release manager](#release-manager) will:
- Send out release notifications, if deemed necessary, on
- The [cncf-buildpacks mailing list](https://lists.cncf.io/g/cncf-buildpacks)
- Twitter
- Post release, you should be able to remove any acceptance test constraints (in [acceptance/invoke/pack.go](acceptance/invoke/pack.go)) in the `featureTests` struct. Create a PR removing them, in order to ensure our acceptance tests are clean.

And with that, you're done!

## Manual Releasing

Expand Down
2 changes: 2 additions & 0 deletions acceptance/acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1664,6 +1664,8 @@ func testAcceptance(
format.compareFunc(output, expectedOutput)
}

imageManager.PullImage(repoName, registryConfig.RegistryAuth())

t.Log("app is runnable")
assertImage.RunsWithOutput(
repoName,
Expand Down

0 comments on commit 07dd22f

Please sign in to comment.