Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter no longer tries to delete app dir #240

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Jan 28, 2020

Fixes #239

This is the quick fix. Some refactoring of the slices logic would allow for more thorough edge case testing and could help prevent issues like this in the future.

Signed-off-by: Emily Casey <ecasey@pivotal.io>
@ekcasey ekcasey requested a review from a team as a code owner January 28, 2020 15:23
@ekcasey ekcasey requested a review from elbandito January 28, 2020 15:24
@ekcasey ekcasey merged commit d930835 into master Jan 29, 2020
@ekcasey ekcasey deleted the fix/239-delete-app-dir-error branch January 29, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exporter tries to delete app dir when all app files are sliced
2 participants