Add -version flag to all binaries #151
Merged
+184
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
previously requested changes
Jul 15, 2019
There was a problem hiding this comment.
Quick comments, let’s chat later also:
- Don’t introduce a new package for the version. Put it in each command, or in the top-level lifecycle package. Package usage should be “wide not deep.”
- Don’t use a single letter variable for package imports
- This breaks the launcher, which cannot use the flag package due to its interface. We don’t want to parse the start command.
jromero
force-pushed
the
feature/143-version
branch
from
6359b85 to
d5d9ea4
Compare
sclevine
reviewed
Jul 15, 2019
sclevine
reviewed
Jul 15, 2019
ameyer-pivotal
force-pushed
the
feature/143-version
branch
from
d5d9ea4 to
bf9e3b3
Compare
ameyer-pivotal
force-pushed
the
feature/143-version
branch
2 times, most recently
from
920b240 to
e632d95
Compare
sclevine
reviewed
Jul 15, 2019
sclevine
reviewed
Jul 15, 2019
- Added acceptance test suite Signed-off-by: Andrew Meyer <ameyer@pivotal.io> Signed-off-by: Javier Romero <jromero@pivotal.io>
ameyer-pivotal
force-pushed
the
feature/143-version
branch
from
e632d95 to
0eaf7b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #143
Signed-off-by: Andrew Meyer ameyer@pivotal.io
Signed-off-by: Javier Romero jromero@pivotal.io