Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expands platform lifecycle tutorial #769

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

expands platform lifecycle tutorial #769

wants to merge 15 commits into from

Conversation

hyounes4560
Copy link
Contributor

@hyounes4560
expands platform lifecycle tutorial
d8f3a6e 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560 hyounes4560 requested a review from a team as a code owner September 23, 2024 01:24
@hyounes4560 hyounes4560 changed the title expands platform lifecycle tutorial WIP: expands platform lifecycle tutorial Sep 23, 2024
AidanDelaney
AidanDelaney requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to look really good.

content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
@hyounes4560
adds more content & reviewer feedback
6ccc5c9 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
adds detect section & updates few links
751f86b 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
edits the last section
bb2241b 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560 hyounes4560 changed the title WIP: expands platform lifecycle tutorial expands platform lifecycle tutorial Sep 24, 2024
AidanDelaney
AidanDelaney reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of analyze section...more to follow

content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Show resolved Hide resolved
@hyounes4560
adds reviewer feedback
363b82e 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
AidanDelaney
AidanDelaney requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have yet to work out an issue with the exporter phase.....

content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
@hyounes4560
adds more reviewer feedback
d17e96a 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
natalieparellano
natalieparellano reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @hyounes4560! As Aidan mentioned this is looking quite good. I added many comments, but only a handful are truly substantive.

content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Show resolved Hide resolved
content/docs/for-platform-operators/tutorials/lifecycle/_index.md Outdated Show resolved Hide resolved
@AidanDelaney @natalieparellano
Fix recursive copy of samples
14353cd 
Make the recursive copy of samples work
correctly in the expected tutorial directory
structure.

Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Aidan Delaney <aidan.delaney@gmail.com>
AidanDelaney
AidanDelaney reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're almost good to go on this. Let's land all of @natalieparellano's suggestions. Then I'll run through it end-to-end again.

@hyounes4560
implements reviewer feedback
493f3bc 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
Merge branch 'lifecycle-tutorial' of github.com:hyounes4560/docs into…
460c91b 
… lifecycle-tutorial
@hyounes4560
Copy link
Contributor Author

@AidanDelaney I added most of @natalieparellano suggestions; left few that are a bit confusing. Please take a look. Thanks

@hyounes4560
adds latest reviewer comments
84c25c7 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
adds reviewer final feedback
21a4b89 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
Copy link
Contributor Author

@AidanDelaney Please take a look; I added the latest comment

hyounes4560 and others added 2 commits October 10, 2024 18:36
@hyounes4560
Merge branch 'main' into lifecycle-tutorial
f159da1
@hyounes4560
adds minor update
78ba3ce 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@AidanDelaney
Copy link
Member

I think #773 will unblock this for landing. I'm happy to land it now...and create a ticket for @AidanDelaney to put in some tests.

natalieparellano
natalieparellano reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added code suggestions for the unresolved comments

@hyounes4560
adds reviewer code suggestions
4c7092c 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
Copy link
Contributor Author

@AidanDelaney I just added the latest code suggestions; this should be ready to go. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidanDelaney AidanDelaney AidanDelaney requested changes

@natalieparellano natalieparellano natalieparellano left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyounes4560 @AidanDelaney @natalieparellano