Use go git #161
Merged
Use go git #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcnew
force-pushed
the
use-go-git
branch
2 times, most recently
from
6195ccd to
ae7c0fb
Compare
matthewmcnew
requested review from
thisisnotashwin,
joaopapereira,
djoyahoy and
c-abramson
and removed request for
thisisnotashwin and
joaopapereira
matthewmcnew
commented
Oct 3, 2019
| opts := &git.FetchOptions{ | ||
| RefSpecs: []config.RefSpec{"refs/*:refs/*"}, | ||
| Auth: resolvedAuth, | ||
| Depth: 0, |
There was a problem hiding this comment.
Of note, For simplicity in this PR: I removed the depth=1 checkout from our current source-init. It would make sense in a future issue to optimize this checkout.
djoyahoy
reviewed
Oct 3, 2019
djoyahoy
reviewed
Oct 3, 2019
djoyahoy
reviewed
Oct 3, 2019
djoyahoy
approved these changes
Oct 3, 2019
c-abramson
approved these changes
Oct 3, 2019
| @@ -1,4 +1,4 @@ | |||
| package secret_test | |||
| package dockercreds | |||
There was a problem hiding this comment.
Are we testing anything internal in this package? if not can we change the package to dockercreds_test?
There was a problem hiding this comment.
We are not currently exporting the k8sGitKeychain. I would like to keep this in the dockercreds package.
matthewmcnew
force-pushed
the
use-go-git
branch
3 times, most recently
from
f274fef to
c250e7a
Compare
| @@ -11,6 +11,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| buildInitBinary = "/layers/org.cloudfoundry.go-mod/app-binary/build-init" // Can be changed to build-init in https://github.com/cloudfoundry/go-mod-cnb/issues/8 | |||
There was a problem hiding this comment.
Cant wait for the go buildpack to start putting the binaries on the path!!!!
thisisnotashwin
approved these changes
Oct 3, 2019
- combine source-init,creds-init,build-init - Mount volumes as CNB user to avoid needing to chown - Run Build Init as CNB user - Move k8sSecretKeychainFactory -> dockercreds package
matthewmcnew
force-pushed
the
use-go-git
branch
from
c250e7a to
84beea9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use go-git to fetch git source builds