Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyze fails on the second build, if the first build fails #339

Closed
ekcasey opened this issue Mar 27, 2020 · 0 comments · Fixed by #340
Closed

analyze fails on the second build, if the first build fails #339

ekcasey opened this issue Mar 27, 2020 · 0 comments · Fixed by #340
Labels
bug Something isn't working

Comments

@ekcasey
Copy link

ekcasey commented Mar 27, 2020 •
edited
Loading

After running a first build and seeing a failure (for good reason), my second build returned this error during analyze

[analyze] ERROR: failed to parse arguments: image argument is required

It appears that the image argument was an empty string in the analyze step container:

  - args:
    - -layers=/layers
    - -group=/layers/group.toml
    - -analyzed=/layers/analyzed.toml
    - -cache-dir=/cache
    - ""
    command:
    - /lifecycle/analyzer

My guess is there is an edge case that breaks this logic but I didn't explore further after seeing the original error.

I was running kpack version 0.0.7
@ekcasey ekcasey added the bug Something isn't working label Mar 27, 2020
matthewmcnew added a commit that referenced this issue Mar 27, 2020
@matthewmcnew
Ensure that an image is provided to the analyze step
a708f31 
 - Check that build.lastBuild exists
 - Utilize last successful build to populate build.spec.lastBuild
 - Fixes #339
@matthewmcnew matthewmcnew mentioned this issue Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that an image is provided to the analyze step buildpacks-community/kpack
1 participant
@ekcasey