Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resolve images in unauthenticated registries #143

Closed
scothis opened this issue Sep 26, 2019 · 0 comments · Fixed by #153
Closed

Unable to resolve images in unauthenticated registries #143

scothis opened this issue Sep 26, 2019 · 0 comments · Fixed by #153

Comments

@scothis
Copy link
Contributor

scothis commented Sep 26, 2019

Building an image targeting an unauthenticated registry completed the builds and published the image to the registry, however, the kpack-controller errors when it is unable to find a secret for that registry (there shouldn't be one). This results in the build's ready condition never becoming true.

Here's what I see in the kpack-controller log with v0.0.4. In this case, registry.kube-system.svc.cluster.local is also an insecure registry, but I doubt that's what's causing issues.

2019-09-26T22:38:00.749Z	ERROR	controller/controller.go:345	Reconcile error	{"error": "resolving keychain for 'registry.kube-system.svc.cluster.local': Secret \"secret for registry.kube-system.svc.cluster.local\" not found", "errorVerbose": "Secret \"secret for registry.kube-system.svc.cluster.local\" not found\nresolving keychain for 'registry.kube-system.svc.cluster.local'\ngithub.com/pivotal/kpack/pkg/registry.newV1Image\n\t/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/pkg/registry/ggcr_image.go:44\ngithub.com/pivotal/kpack/pkg/registry.NewGoContainerRegistryImage\n\t/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/pkg/registry/ggcr_image.go:22\ngithub.com/pivotal/kpack/pkg/registry.(*ImageFactory).NewRemote\n\t/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/pkg/registry/image_factory.go:14\ngithub.com/pivotal/kpack/pkg/cnb.(*RemoteMetadataRetriever).GetBuiltImage\n\t/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/pkg/cnb/cnb_metadata.go:65\ngithub.com/pivotal/kpack/pkg/reconciler/v1alpha1/build.(*Reconciler).Reconcile\n\t/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/pkg/reconciler/v1alpha1/build/build.go:95\ngithub.com/pivotal/kpack/vendor/github.com/knative/pkg/controller.(*Impl).processNextWorkItem\n\t/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/vendor/github.com/knative/pkg/controller/controller.go:330\ngithub.com/pivotal/kpack/vendor/github.com/knative/pkg/controller.(*Impl).Run.func1\n\t/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/vendor/github.com/knative/pkg/controller/controller.go:282\nruntime.goexit\n\t/layers/org.cloudfoundry.go-compiler/go/src/runtime/asm_amd64.s:1357"}
github.com/pivotal/kpack/vendor/github.com/knative/pkg/controller.(*Impl).handleErr
	/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/vendor/github.com/knative/pkg/controller/controller.go:345
github.com/pivotal/kpack/vendor/github.com/knative/pkg/controller.(*Impl).processNextWorkItem
	/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/vendor/github.com/knative/pkg/controller/controller.go:331
github.com/pivotal/kpack/vendor/github.com/knative/pkg/controller.(*Impl).Run.func1
	/layers/org.cloudfoundry.dep/packages/src/github.com/pivotal/kpack/vendor/github.com/knative/pkg/controller/controller.go:282
matthewmcnew added a commit that referenced this issue Sep 30, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Sep 30, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Sep 30, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Sep 30, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Sep 30, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Oct 1, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Oct 1, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Oct 1, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Oct 1, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Oct 1, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Oct 1, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Oct 1, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
matthewmcnew added a commit that referenced this issue Oct 1, 2019
- Allow auth for images to be fetched via kubernetes/credentialprovider
- Allow images/builds to be built with unauthenticated registries
- Resolves #143
- Remove ImageRef interface
- Images are fetched with concrete SecretRef
- Builder auth can be fetched with default service account imagePullSecrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants