Resolve concurrent map write error in remote git resolver

- Move logic that can cause concurrent map writes to an init function

pkg/git/remote_git_resolver.go

@@ -15,25 +15,20 @@ const defaultRemote = "origin"
 
 type remoteGitResolver struct{}
 
+func init() {
+	httpsTransport, err := getHttpsTransport()
+	if err != nil {
+		return
+	}
+	client.InstallProtocol("https", httpsTransport)
+}
+
 func (*remoteGitResolver) Resolve(auth transport.AuthMethod, sourceConfig corev1alpha1.SourceConfig) (corev1alpha1.ResolvedSourceConfig, error) {
 	remote := gogit.NewRemote(memory.NewStorage(), &config.RemoteConfig{
 		Name: defaultRemote,
 		URLs: []string{sourceConfig.Git.URL},
 	})
 
-	httpsTransport, err := getHttpsTransport()
-	if err != nil {
-		return corev1alpha1.ResolvedSourceConfig{
-			Git: &corev1alpha1.ResolvedGitSource{
-				URL:      sourceConfig.Git.URL,
-				Revision: sourceConfig.Git.Revision,
-				Type:     corev1alpha1.Unknown,
-				SubPath:  sourceConfig.SubPath,
-			},
-		}, nil
-	}
-	client.InstallProtocol("https", httpsTransport)
-
 	refs, err := remote.List(&gogit.ListOptions{
 		Auth: auth,
 	})