Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1170: upgrade typescript version to 2.6.2 (closes #1170) #1171

Merged
merged 5 commits into from
Jan 24, 2018

Conversation

giogonzo
Copy link
Member

@giogonzo giogonzo commented Jan 20, 2018

Closes #1170

Test Plan

test build and start look 👍
some more context on the TS4023 error: microsoft/TypeScript#5711
and on the "Arbitrary expression.." one: https://github.com/Microsoft/TypeScript/wiki/Breaking-Changes#arbitrary-expressions-are-forbidden-in-export-assignments-in-ambient-contexts

tests performed

A Test Plan is used to show what you tested to make sure your code works fine. You should write here all that you did to test, and provide some results of your testing.

These results can be screenshots, query results, or even just pointers to unit tests that successfully passed.

cross browser compatibility

Should be compatible with every browser below. Check the ones you tested!

  • Google Chrome
  • Internet Explorer

tests not performed (domain coverage)

At times not everything can be tested, and writing what hasn't been tested is just as important as writing what has been tested.

An example of partial test is a field displaying 4 possible values. If 3 values are tested, with screenshots, and 1 is not, then it should be mentioned here.

@nemobot nemobot added WIP Issues in progress breaking Issues that introduce a breaking change that must be release with a new "major" labels Jan 20, 2018
@nemobot nemobot added in review Issues with an open PR waiting to be reviewed and removed WIP Issues in progress labels Jan 20, 2018
Copy link
Contributor

@FrancescoCioria FrancescoCioria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I think we should deeply test Tablo typings as soon as we have time/the change)

@nemobot nemobot added waiting for merge Issues with an open PR ready to be merged and removed in review Issues with an open PR waiting to be reviewed labels Jan 21, 2018
@FrancescoCioria FrancescoCioria merged commit 4004307 into master Jan 24, 2018
@nemobot
Copy link
Contributor

nemobot commented Jan 24, 2018

@nemobot nemobot removed the waiting for merge Issues with an open PR ready to be merged label Jan 24, 2018
@FrancescoCioria FrancescoCioria deleted the 1170-upgrade_typescript_version_to branch January 24, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Issues that introduce a breaking change that must be release with a new "major"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants