Modify tap to support bk CLI v3.0 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dabarrell can you help me get people to review this? |
|
For reference, the |
jradtilbrook
requested review from
a team,
mcncl,
PriyaSudip and
lizrabuya
and removed request for
a team
jradtilbrook
changed the title
|
And buildkite/cli#306 will actually start pushing the new formula to this repository |
mcncl
approved these changes
Jul 2, 2024
sgerrand
added a commit
to sgerrand/homebrew-brewfile
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of releasing a new major version of the CLI as v3.0.
We'll have a period of time where it is not the default, so will be released at
bk@3. The formula does not exist yet but will be created in another PR.This should not change anything user facing at the moment. It adds the install target
bk@2though. All others,bk,cli,buildkite-cliall exist and point to the current v2 release.A subsequent change will introduce the
BkAT3formula, allowing it to be installed withbrew install bk@3. This will be a beta version of the CLI for a short while, hence the specific install target (and the default remaining as v2). After a beta period, we will continue to support thebk@2target, but will change the default to install v3.Testing
Pull down this branch and run
brew tap buildkite/pr .to tell brew about this tap. You can then see thatbrew info buildkite/pr/bk|bk@2|cli|buildkite-cliall still exist and install v2 of the CLI