remove DRY_RUN flag from AMI cleaning script #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've run some test builds in dry mode, and spot checked the job logs for multiple regions. Everything I checked looked as expected: * all regions show elastic stack AMIs tagged with a version are left untouched * all regions show only elastic stack AMIs in the list * all regions cap the deletions at only 10 images (for now) This will require expanding the IAM role to permit deregistering images and deleting snapshots. I propose leaving the 10-image cap for now. In the unlikely event of a mistake, this will limit the blast radius of deregistered images. We can increase the number once we build confidence.
yob
commented
Dec 18, 2024
| @@ -4,7 +4,7 @@ steps: | |||
| agents: | |||
| queue: "oss-deploy" | |||
| env: | |||
| DRY_RUN: true | |||
| # DRY_RUN: true | |||
There was a problem hiding this comment.
I've left this in but commented out, for discoverability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run some test builds in dry mode, and spot checked the job logs for multiple regions. Everything I checked looked as expected:
This will require expanding the IAM role to permit deregistering images and deleting snapshots.
I propose leaving the 10-image cap for now. In the unlikely event of a mistake, this will limit the blast radius of deregistered images. We can increase the number once we build confidence.