Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate step environment to job environment #44

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Conversation

lox
Copy link

@lox lox commented Mar 12, 2019

We weren't correctly propagating environment from steps into the job environment.

My test pipeline was:

steps:
  - label: "env test"
    command: "env | grep -e '^TEST_ENV'"
    env: 
      TEST_ENV: "llamas"

Closes #40.

@tduffield
Copy link

I can confirm that fixes it on my end as well! 🙇

@lox lox merged commit 0973c2c into master Mar 12, 2019
@lox lox deleted the propagate-step-env branch March 12, 2019 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants