api scopes for all build commands #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcncl
requested review from
lizrabuya,
PriyaSudip and
jykingston
as code owners
lizrabuya
previously requested changes
Jan 15, 2025
| @@ -28,6 +29,23 @@ func NewCmdBuildCancel(f *factory.Factory) *cobra.Command { | |||
| Long: heredoc.Doc(` | |||
| Cancel the given build. | |||
| `), | |||
| PreRunE: func(cmd *cobra.Command, args []string) error { | |||
There was a problem hiding this comment.
Request to optimise preRun function that appears on several portions in code
There was a problem hiding this comment.
Sure! How would you optimise this code? I'm not overly certain on a way to reduce it further
There was a problem hiding this comment.
Oh, the code to check the scope is fine. But maybe move the implementation in one place (like in pkg/cmd/build/build.go) and refer to it in the other subcommands ?
There was a problem hiding this comment.
hi @mcncl , we can implement this feedback in an enhancement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes