Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-buildkite to v4.0.0 #380

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Update go-buildkite to v4.0.0 #380

merged 3 commits into from
Oct 22, 2024

Conversation

moskyb
Copy link
Contributor

@moskyb moskyb commented Oct 21, 2024

This PR updates go-buildkite to v4! It deals with the major breaking changes:

  • strips out the many pointer derefs we had, because they're no longer needed!
  • passes contexts to all of the calls to go-buildkite calls
    • there's a couple in the builds resolver that i've just plugged context.TODO() into, because the build resolver scares me and i'm afraid to touch it

@tommeier tommeier requested a review from sj26 October 21, 2024 09:51
@sj26
Copy link
Member

sj26 commented Oct 21, 2024 •
edited
Loading

This looks pretty fine to me, but looks like a failed build at the moment 👀

sj26
sj26 previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@sj26 sj26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 in principle, when green

@moskyb moskyb enabled auto-merge (squash) October 22, 2024 03:18
@moskyb moskyb merged commit 6b9ce44 into main Oct 22, 2024
1 check passed
@moskyb moskyb deleted the go-buildkite-v4 branch October 22, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PriyaSudip PriyaSudip PriyaSudip approved these changes

@sj26 sj26 sj26 left review comments

@mcncl mcncl Awaiting requested review from mcncl mcncl is a code owner

@lizrabuya lizrabuya Awaiting requested review from lizrabuya lizrabuya is a code owner

@jykingston jykingston Awaiting requested review from jykingston jykingston is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moskyb @sj26 @PriyaSudip