Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using a file for env #377

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Support using a file for env #377

merged 2 commits into from
Oct 9, 2024

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented Oct 9, 2024

Changes

We implemented support for -e flags at build new time, but some folks have a lot of environment variables they wish to set.

  • Support using a file, -f for the environment

I'm open to suggestions if this flag/short version could be better

lizrabuya
lizrabuya approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@lizrabuya lizrabuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcncl mcncl merged commit d5343af into main Oct 9, 2024
1 check passed
@mcncl mcncl deleted the build_env_file branch October 9, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrabuya lizrabuya lizrabuya approved these changes

@PriyaSudip PriyaSudip Awaiting requested review from PriyaSudip PriyaSudip is a code owner

@jykingston jykingston Awaiting requested review from jykingston jykingston is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcncl @lizrabuya