Don't print empty annotations #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcncl
commented
Jun 19, 2024
•
mcncl
commented
…rders - Implement annotation count to use with conditional print
mcncl
requested review from
jradtilbrook,
lizrabuya and
PriyaSudip
as code owners
| for _, a := range buildAnnotations { | ||
| summary += annotation.AnnotationSummary(&a) | ||
| annotationCount := 0 | ||
| if len(annotation.AnnotationSummary(&a)) < 230 { |
There was a problem hiding this comment.
Is this special 230 something to do with the annotation box, etc?
There was a problem hiding this comment.
Yeah, the total len with an empty annotation is 227, this allows for special chars that maybe use an additional byte or two
There was a problem hiding this comment.
Hmm, what if we used glamour to render this instead. It handles markdown, which is a superset of HTML. A quick test with a string with markdown and html anchor tags and it works nicely
PriyaSudip
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.