upgrade go-git from v4 to v5 #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yob
force-pushed
the
go-git-v5
branch
3 times, most recently
from
c5faac2 to
9212dc9
Compare
yob
added a commit
that referenced
this pull request
Feb 28, 2024
While working on #210 I noticed there was a new major release of the docker compose plugin. In the end I didn't need the upgrade for that PR, so I thought I'd pull it out into a dedicated one.
In #206 gopkg.in/src-d/go-git.v4 was added as a dependency, which has led to a couple of GH security alerts. Reading the details on the two alerts, it seems like we're unlikely to be impacted. We're using it to parse git URLs and not clone repositories onto a filesystem, so we're not working with untrusted input. I thought I'd try upgrading the dependency to v5 anyway though. We'll be on the latest version which will help with keeping the project maintainable, and maybe the security alerts will go away as a side effect. I had to bump the default 1 min timeout on golint to get the linting step to pass. Looking at some recent builds golint was taking very close to 1min, so I guess this was enough to push it over? It only takes a few seconds on my laptop, maybe we need better/bigger CI instances?
mcncl
approved these changes
Feb 28, 2024
mcncl
added a commit
that referenced
this pull request
Feb 28, 2024
While working on #210 I noticed there was a new major release of the docker compose plugin. In the end I didn't need the upgrade for that PR, so I thought I'd pull it out into a dedicated one. Co-authored-by: mcncl <git@benmcnicholl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #206 gopkg.in/src-d/go-git.v4 was added as a dependency, which has led to a couple of GH security alerts.
Reading the details on the two alerts, it seems like we're unlikely to be impacted. We're using it to parse git URLs and not clone repositories onto a filesystem, so we're not working with untrusted input.
I thought I'd try upgrading the dependency to v5 anyway though. We'll be on the latest version which will help with keeping the project maintainable, and maybe the security alerts will go away as a side effect.
I had to bump the default 1 min timeout on golint to get the linting step to pass. Looking at some recent builds golint was taking very close to 1min, so I guess this was enough to push it over? It only takes a few seconds on my laptop, maybe we need better/bigger CI instances?