Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUP 1748 Implement bk build cancel and code refactoring #203

Merged
merged 3 commits into from
Feb 14, 2024
Merged

SUP 1748 Implement bk build cancel and code refactoring #203

merged 3 commits into from
Feb 14, 2024

Conversation

lizrabuya
Copy link
Contributor

@lizrabuya lizrabuya commented Feb 8, 2024 •
edited
Loading

This PR implements the bk build cancel <number> <pipeline> command.

This PR also includes some code refactoring into the bk build code:

  • open in web browser implementation to the bk build commands
  • added a generic function to render results for bk build commands
  • added a status for cancelling on bk build view when a build is still cancelling
  • Removed an unknown build status item
  • update help text for bk build rebuild

@lizrabuya lizrabuya marked this pull request as ready for review February 8, 2024 22:33
@lizrabuya lizrabuya merged commit cbf2afe into 3.x Feb 14, 2024
1 check passed
@lizrabuya lizrabuya deleted the sup-1748-bk-build-cancel branch February 14, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jradtilbrook jradtilbrook jradtilbrook approved these changes

@mcncl mcncl Awaiting requested review from mcncl mcncl is a code owner

@james2791 james2791 Awaiting requested review from james2791

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizrabuya @jradtilbrook