Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer deref on executor.go:103 #3150

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix nil pointer deref on executor.go:103 #3150

merged 1 commit into from
Jan 7, 2025

Conversation

DrJosh9000
Copy link
Contributor

Description

e.shell isn't set yet.

Context

#3149

Changes

Use tempLog instead of e.shell to log the error.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

@DrJosh9000 DrJosh9000 enabled auto-merge January 6, 2025 22:13
@DrJosh9000 DrJosh9000 merged commit b6015a8 into main Jan 7, 2025
1 check passed
@DrJosh9000 DrJosh9000 deleted the nil-pointer-executor-103 branch January 7, 2025 00:23
@artem-zinnatullin artem-zinnatullin mentioned this pull request Jan 9, 2025
Closed
@moskyb moskyb mentioned this pull request Jan 9, 2025
Merged
@artem-zinnatullin artem-zinnatullin mentioned this pull request Jan 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-zinnatullin artem-zinnatullin artem-zinnatullin approved these changes

@CerealBoy CerealBoy CerealBoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrJosh9000 @CerealBoy @artem-zinnatullin