Use job tokens for log chunk uploads #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tessereth
force-pushed
the
job-tokens-chunk-uploads
branch
2 times, most recently
from
978249e to
9e7e25f
Compare
DrJosh9000
approved these changes
Sep 17, 2024
Co-authored-by: Josh Deprez <jd@buildkite.com>
tessereth
force-pushed
the
job-tokens-chunk-uploads
branch
from
098cb3f to
0e5e12e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2915 we refactored a bunch of this code. In the process, we now take a copy of the
apiClientobject inNewJobRunnerbefore we replace theapiClientwith a new one that uses the job token rather than the session token. We then use the copy for log streaming. This means agents since v3.77.0 use session tokens rather than job tokens for chunk uploads.I've tested it locally and this change fixes the problem. I'm not sure how to add regression tests for this though.This is tested by updating the fake bk server in the integration tests to require job tokens for everything.