-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement customizable ticker interval to mitigate buildkite api rate limit Issues #279
feat: implement customizable ticker interval to mitigate buildkite api rate limit Issues #279
Conversation
70a2ca1
to
f82e637
Compare
f82e637
to
0be59c3
Compare
996f4da
to
db9d832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for raising this, and sorry for the delay in getting around to it. Our main discussions have been around how this would negatively impact the speed at which jobs would be picked up, when a short-term fix is to increase the GraphQL quota, and longer-term improvements are being planned. But as we discussed yesterday, we'll accept this as a potentially useful configuration option for all customers.
I've rebased and pushed a handful of small tweaks. I'm planning on merging this now, but if you have any comments or things you would have done differently, please let us know!
This pull request introduces the capability to customize the ticker interval within our system. Previously, a static ticker interval of 1 second significantly restricted operations, especially when running more than 10 controllers, by exceeding Buildkite’s GraphQL API complexity rate limits. This enhancement provides a workaround that allows users to adjust the ticker interval, thereby optimizing their usage to avoid hitting these limits.