Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement customizable ticker interval to mitigate buildkite api rate limit Issues #279

Merged
merged 10 commits into from
May 30, 2024

Conversation

42atomys
Copy link
Contributor

This pull request introduces the capability to customize the ticker interval within our system. Previously, a static ticker interval of 1 second significantly restricted operations, especially when running more than 10 controllers, by exceeding Buildkite’s GraphQL API complexity rate limits. This enhancement provides a workaround that allows users to adjust the ticker interval, thereby optimizing their usage to avoid hitting these limits.

@DrJosh9000 DrJosh9000 self-requested a review May 30, 2024 02:57
@DrJosh9000 DrJosh9000 force-pushed the feat/allow-customize-poll-interval branch from 70a2ca1 to f82e637 Compare May 30, 2024 05:30
@DrJosh9000 DrJosh9000 force-pushed the feat/allow-customize-poll-interval branch from f82e637 to 0be59c3 Compare May 30, 2024 05:36
@DrJosh9000 DrJosh9000 force-pushed the feat/allow-customize-poll-interval branch from 996f4da to db9d832 Compare May 30, 2024 05:40
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this, and sorry for the delay in getting around to it. Our main discussions have been around how this would negatively impact the speed at which jobs would be picked up, when a short-term fix is to increase the GraphQL quota, and longer-term improvements are being planned. But as we discussed yesterday, we'll accept this as a potentially useful configuration option for all customers.

I've rebased and pushed a handful of small tweaks. I'm planning on merging this now, but if you have any comments or things you would have done differently, please let us know!

@DrJosh9000 DrJosh9000 merged commit 8eb53d6 into buildkite:main May 30, 2024
1 check passed
@42atomys 42atomys deleted the feat/allow-customize-poll-interval branch August 7, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants