Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress option #467

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Add progress option #467

merged 2 commits into from
Jan 14, 2025

Conversation

paymand
Copy link
Contributor

@paymand paymand commented Jan 13, 2025

Change

  1. Add support for progress option.
  2. Add a unit test.

Problem/Why:

  1. We have health probes defined for services
  2. Our services depend on each other for example:
    depends_on:
      elasticsearch:
        condition: service_healthy

When using wait: truethe logs explode:
image

I can see that passing --progress quiet to docker compose hides the progress info locally, but I have no way of specifying that on CI.

@paymand paymand requested a review from a team as a code owner January 13, 2025 14:32
@paymand
Copy link
Contributor Author

paymand commented Jan 13, 2025

CC @toote

@paymand paymand changed the title Add progress option to Docker Compose plugin configuration Add progress option Jan 13, 2025
@paymand
Copy link
Contributor Author

paymand commented Jan 14, 2025

and CC @tomowatt. Pretty quiet here in this repo 😬

@tomowatt
Copy link
Contributor

Hey @paymand
Thank you for this PR, wasn't personally aware of this flag in Docker Compose but all LGTM!

@tomowatt tomowatt merged commit ddec64a into buildkite-plugins:master Jan 14, 2025
1 check passed
@paymand
Copy link
Contributor Author

paymand commented Jan 14, 2025

Thanks @tomowatt. Could you create a release as well? 🙏

@tomowatt
Copy link
Contributor

@paymand done v5.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomowatt tomowatt tomowatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paymand @tomowatt