Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-2585: Add Support for changing Build Drivers #463

Merged
merged 50 commits into from
Nov 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
4b68d2b
feat: add docker-driver parameter
tomowatt Oct 28, 2024
81e6b5a
feat: add pre-command hook to create builder instance
tomowatt Oct 28, 2024
8b49c39
fix: remove docker driver reference as cannot be created
tomowatt Oct 28, 2024
0806ccc
feat: add clean up of Docker Builder Instances
tomowatt Oct 28, 2024
790e996
docs: add information on docker-driver parameter
tomowatt Oct 28, 2024
f8bbba1
refactor: rename parameter to avoid confusion with default 'docker' d…
tomowatt Oct 28, 2024
f627efd
fix: correct expansion when not set
tomowatt Oct 28, 2024
52d193d
fix: correct pattern match of drivers and rename to differentiate
tomowatt Oct 28, 2024
cc35a4e
refactor: set and export Builder Instance Name due to contraint
tomowatt Nov 4, 2024
6234c9f
fix: pass in --driver flag
tomowatt Nov 4, 2024
127d622
feat: Add bootstrapping of Builder Instance during creation
tomowatt Nov 4, 2024
3c71e5c
fix: double quote to prevent globbing/word splitting
tomowatt Nov 4, 2024
a65eee5
style: match style of parameters
tomowatt Nov 4, 2024
17a9403
refactor: move Builder properties into object parameter for clarity a…
tomowatt Nov 14, 2024
10035c7
refactor: separate logic for creating and using builder instances for…
tomowatt Nov 14, 2024
c9ca123
feat: add shared func for checking if a builder instance exists for u…
tomowatt Nov 14, 2024
b6fe75a
refactor: rework removing builder instances using plugin parameters i…
tomowatt Nov 14, 2024
72ff0cb
docs: Update README with details on builder parameters
tomowatt Nov 14, 2024
795f12e
feat: add logic for checking remote-address with remote driver
tomowatt Nov 14, 2024
11d4b16
tests: add test for no builder parameters
tomowatt Nov 14, 2024
6549d6d
tests: add tests for invalid Builder Name
tomowatt Nov 14, 2024
f10dcb2
tests: add tests for creating Builder with invalid Driver
tomowatt Nov 14, 2024
0f2e912
style: update parameter headers to match format
tomowatt Nov 15, 2024
332ee71
docs: update driver-opt docs and example
tomowatt Nov 15, 2024
6f38b30
refactor: remove export and add reading of Builder Name to pre-exit f…
tomowatt Nov 15, 2024
dcd899b
fix: correct expansion of builder create parameters
tomowatt Nov 15, 2024
62c7cb0
feat: restrict builder properties to those listed
tomowatt Nov 15, 2024
35bb0ec
chore: correct message when trying to remove Builder Instance that do…
tomowatt Nov 15, 2024
b6c221f
feat: add parameter for keep-daemon and keep-state when removing Buil…
tomowatt Nov 15, 2024
93f65a7
fix: correct adding args to array
tomowatt Nov 15, 2024
16af6fe
feat: add export for debugging tests
tomowatt Nov 16, 2024
1efcaa8
tests: add tests for creating builder instances with valid driver and…
tomowatt Nov 16, 2024
fe62bc0
tests: add teardown of docker stubs
tomowatt Nov 16, 2024
2005cd1
tests: add tests for using builder instance when existing and not
tomowatt Nov 16, 2024
38c8637
tests: add tests for removing Builder instances
tomowatt Nov 18, 2024
d2b12a7
style: update message to a warning to highlight potential misconfigur…
tomowatt Nov 18, 2024
c2d69e8
docs: update information on 'create' to match logic
tomowatt Nov 19, 2024
7433e00
docs: Add details and examples for managing Builder Instances
tomowatt Nov 19, 2024
38c0121
docs: Add details and examples for remote cache with Builder Instances
tomowatt Nov 19, 2024
1262bbe
docs: correct examples for linter
tomowatt Nov 19, 2024
ee4311c
docs: correct examples
tomowatt Nov 19, 2024
316af29
fix: correct parameter type
tomowatt Nov 19, 2024
fbd6bef
refactor: simply builder_instance_args array construction
tomowatt Nov 19, 2024
c4751c3
refactor: simply builder_remove_args array construction and usage
tomowatt Nov 19, 2024
2773c6b
docs: update example of removing created Builder Instance
tomowatt Nov 20, 2024
d488209
tests: update assertions to match existing style used
tomowatt Nov 20, 2024
4d0c062
tests: remove teardown and add explicity unstubs for clarity on where…
tomowatt Nov 20, 2024
da5648e
docs: add details on using remote registries and requiring auth
tomowatt Nov 20, 2024
7568b8c
docs: correct examples with specification of services in cache-from a…
tomowatt Nov 21, 2024
8dd5ed5
feat: add warning when builder instance created but not used
tomowatt Nov 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: Add bootstrapping of Builder Instance during creation
  • Loading branch information
tomowatt committed Nov 4, 2024
commit 127d622f8e1c1557b7a1e87c82d0d05d353391ed
2 changes: 1 addition & 1 deletion hooks/pre-command
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ if [[ "${build_driver}" =~ ^(${valid_drivers})$ ]]; then
# Use Buildkite Job ID to create unique builder instance instance per Job
# add prefix due constraint needing to start with a letter
export BUILDER_INSTANCE_NAME="${build_driver}-${BUILDKITE_JOB_ID}"
docker buildx create --driver "${build_driver}" --name ${BUILDER_INSTANCE_NAME} --use
docker buildx create --driver "${build_driver}" --name ${BUILDER_INSTANCE_NAME} --use --bootstrap
export BUILD_DRIVER_INSTANCE=true
elif [[ -z "$build_driver" ]]; then
echo "~~~ :docker: Using Default Build Driver 'docker'"