[SS] Refactor UFFD to prepare for balloon #8406
Open
+106
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggie-lou
force-pushed
the
tighten_up_uffd
branch
from
c6071a2 to
e5fdd5b
Compare
maggie-lou
force-pushed
the
log_compressed_bytes
branch
from
39b8e05 to
aa4ad8a
Compare
maggie-lou
force-pushed
the
tighten_up_uffd
branch
from
e5fdd5b to
8486062
Compare
bduffany
approved these changes
Feb 14, 2025
maggie-lou
force-pushed
the
tighten_up_uffd
branch
from
8486062 to
954baf5
Compare
maggie-lou
force-pushed
the
tighten_up_uffd
branch
2 times, most recently
from
fcab792 to
5dba0b0
Compare
maggie-lou
force-pushed
the
tighten_up_uffd
branch
from
5dba0b0 to
b9d26c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make my balloon PR easier to review, refactor the UFFD code to prepare for balloon-related changes. The major change in this PR is that rather than {read page fault event, resolve page fault event} in a loop, we will {read all available page fault events, resolve all page faults} in a loop. This behavior is required to handle balloon events (comments coming in a future PR) but should be a no-op for now