Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SS] Add file name to metric for compressed bytes uploaded for snapshots #8345

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

maggie-lou
Copy link
Contributor

This graph provides a misleading view of how much snapshot data we're writing to the remote cache, because it tracks non-compressed data and doesn't account for data that already exists in the cache.

Add file name to the metric that tracks compressed data that is actually written to the cache

Copy link
Member

@tylerwilliams tylerwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like what it says on the tin for this CL, but have questions about the implementation :P

enterprise/server/remote_execution/snaputil/snaputil.go Outdated Show resolved Hide resolved
enterprise/server/remote_execution/snaputil/snaputil.go Outdated Show resolved Hide resolved
@maggie-lou maggie-lou merged commit ead8c9c into master Feb 11, 2025
15 of 16 checks passed
@maggie-lou maggie-lou deleted the track_compressed_snapshot branch February 11, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants