Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedupe gcs blob writes #8338

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Dedupe gcs blob writes #8338

merged 2 commits into from
Feb 7, 2025

Conversation

tylerwilliams
Copy link
Member

No description provided.

bduffany
bduffany approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@bduffany bduffany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the Contains() check in byte_stream_server not already do this? (LGTM if not)

@tylerwilliams
Copy link
Member Author

does the Contains() check in byte_stream_server not already do this? (LGTM if not)

Not in this case because we're only use gcs for the blob storage here.

@tylerwilliams
Copy link
Member Author

I had another go at this using gcs storage preconditions instead of calling Exists -- hoping that's fewer RPCs but will test it in dev and see if it really resolves the issue.

@tylerwilliams tylerwilliams merged commit 6b1596b into master Feb 7, 2025
7 of 15 checks passed
@tylerwilliams tylerwilliams deleted the dedupe_gcs_writes branch February 7, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siggisim siggisim siggisim approved these changes

@bduffany bduffany bduffany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tylerwilliams @siggisim @bduffany