DB API refresh part 2 #5508
Merged
DB API refresh part 2 #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates most of the remaining call sites.
tylerwilliams
approved these changes
Dec 11, 2023
bduffany
approved these changes
Dec 12, 2023
| @@ -8,6 +8,7 @@ import ( | |||
| "errors" | |||
| "flag" | |||
| "fmt" | |||
| "github.com/buildbuddy-io/buildbuddy/server/util/db" | |||
| @@ -2,6 +2,7 @@ package execution_service | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/buildbuddy-io/buildbuddy/server/util/db" | |||
| @@ -6,6 +6,7 @@ import ( | |||
| "crypto/x509" | |||
| "encoding/pem" | |||
| "fmt" | |||
| "github.com/buildbuddy-io/buildbuddy/server/interfaces" | |||
enterprise/server/iprules/iprules.go
Outdated
| @@ -3,6 +3,7 @@ package iprules | |||
| import ( | |||
| "context" | |||
| "flag" | |||
| "github.com/buildbuddy-io/buildbuddy/server/util/db" | |||
| @@ -3,6 +3,7 @@ package usage_test | |||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "github.com/buildbuddy-io/buildbuddy/server/util/db" | |||
| @@ -3,6 +3,7 @@ package invocationdb | |||
| import ( | |||
| "context" | |||
| "errors" | |||
| "github.com/buildbuddy-io/buildbuddy/server/util/db" | |||
| // foos, err := db.All(rq, &tables.Foo{}) | ||
| // | ||
| // TODO(vadim): check if there are any ScanRows calls that can be converted to ScanAll. | ||
| func ScanAll[T any](rq interfaces.DBRawQuery, t *T) ([]*T, error) { |
There was a problem hiding this comment.
imo having two funcs ScanRows and ScanAll is a bit confusing since they sound sort of the same - maybe naming this something like CollectRows or ScanToSlice could make sense?
There was a problem hiding this comment.
I renamed ScanRows to ScanEach. Hope that differentiates it enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates most of the remaining call sites.
Related issues: N/A