Skip to content

Commit

Permalink
executor: add support for minReadySeconds (#77)
Browse files Browse the repository at this point in the history
Provide a configuration that would let user slow down the replacement of
pods during a RollingUpdate. This should give newer pods time to warm up
and reach the desired action execution speed, before shutting down the
older pods.
  • Loading branch information
sluongng authored Jan 9, 2024
1 parent fe08276 commit bedec2d
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/buildbuddy-executor/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: BuildBuddy Executor
name: buildbuddy-executor
version: 0.0.212 # Chart version
version: 0.0.213 # Chart version
appVersion: 2.35.0 # Version of deployed app
keywords:
- buildbuddy
Expand Down
3 changes: 3 additions & 0 deletions charts/buildbuddy-executor/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ spec:
tolerations:
{{- toYaml .Values.tolerations | nindent 8 }}
{{- end }}
{{- if .Values.minReadySeconds}}
minReadySeconds: {{ .Values.minReadySeconds }}
{{- end }}
containers:
{{- if .Values.extraContainers }}
{{- toYaml .Values.extraContainers | nindent 8 }}
Expand Down
9 changes: 9 additions & 0 deletions charts/buildbuddy-executor/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,15 @@ config:
local_cache_size_bytes: 5000000000 # 5GB
docker_socket: /var/run/docker.sock

# Configuration for Deployment Rollout Staggering
# The 'minReadySeconds' config delays the rollout process during a RollingUpdate. This delay allows the
# new Executor time for initialization, which includes picking up new actions, downloading necessary
# container images and inputs. As a result, it prevents the immediate replacement of the old Executor.
# By setting this config, the impact of 'helm upgrade' on ongoing operations is minimized, ensuring a
# smoother transition between different chart releases.
#
# minReadySeconds: 300

## Additional env vars
extraEnvVars: []

Expand Down

0 comments on commit bedec2d

Please sign in to comment.