Provide better decoupling between the VFS and other parts of Buildbarn #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
force-pushed
the
eschouten/20240918-apply
branch
2 times, most recently
from
a590c43
to
bcd70b8
Compare
This allows us to get rid of some local patches, as bazel_remote_apis now works well for us right out of the box. While there, switch from git_override() to single_version_override() where possible. This no longer requires us to fill in explicit commit hashes.
EdSchouten
force-pushed
the
eschouten/20240918-apply
branch
2 times, most recently
from
7347308
to
0250622
Compare
These are all operations that are used outside of the VFS to extract data out of leaf nodes. By implementing all of these operations through VirtualApply(), we can keep the VFS API decoupled from the rest of Buildbarn.
With all of the methods except Link() and Unlink() removed, the name LinkableLeaf seems more fitting.
EdSchouten
force-pushed
the
eschouten/20240918-apply
branch
from
0250622
to
bdf756b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new VirtualApply() method that is similar to Directory.Apply(). Namely, it can be used to apply arbitrary operations against nodes, passing through the wrapped Directory/Leaf objects of HandleAllocator. This makes it possible to significantly trim down NativeLeaf. While there, we rename NativeLeaf to LinkableLeaf.