Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose: Add bb-remote-asset to setup #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docker-compose: Add bb-remote-asset to setup #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions docker-compose/config/remote-asset.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
local common = import 'common.libsonnet';
{
fetcher: {
caching: {
fetcher: {
http: {
allowUpdatesForInstances: ['fuse', 'hardlinking'],
contentAddressableStorage: common.blobstore.contentAddressableStorage,
},
},
},
},

assetCache: {
actionCache: {
blobstore: common.blobstore,
},
},
global: common.global,
grpcServers: [{
listenAddresses: [':8984'],
authenticationPolicy: { allow: {} },
}],
allowUpdatesForInstances: ['foo'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more descriptive name, or just a comment, about what this instance name refers to?

maximumMessageSizeBytes: 16 * 1024 * 1024 * 1024,
}
12 changes: 12 additions & 0 deletions docker-compose/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,3 +124,15 @@ services:
- ./volumes/worker-hardlinking-ubuntu22-04:/worker
depends_on:
- runner-installer

remote-asset:
# TODO(minor-fixes): Replace with actual container once pushed to ghcr
image: bazel/cmd/bb_remote_asset:bb_remote_asset_container
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be merged as-is until this image is put somewhere public (ghcr.io?)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating the image reference now when ghcr.io/buildbarn/bb-remote-asset:20230910T205857Z-52b25db is available?

command:
- /config/remote-asset.jsonnet
expose:
- 9980
ports:
- 8984:8984
volumes:
- ./config:/config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please add an empty line at the end of file.