fix(rust): use the same in-memory database for the vault used in nif #7001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etorreborre
force-pushed
the
etorreborre/fix/nif-database
branch
from
ee71d56
to
8c6d635
Compare
etorreborre
force-pushed
the
etorreborre/fix/nif-database
branch
from
8c6d635
to
3c2d91c
Compare
| @@ -89,17 +92,20 @@ fn identities_ref() -> NifResult<Arc<Identities>> { | |||
|
|
|||
| fn load_memory_vault() -> bool { | |||
| block_future(async move { | |||
| let identity_vault = SoftwareVaultForSigning::create().await.unwrap(); | |||
| let secure_channel_vault = SoftwareVaultForSecureChannels::create().await.unwrap(); | |||
| let database = SqlxDatabase::in_memory("in-memory-vault").await.unwrap(); | |||
There was a problem hiding this comment.
why no connection pool is created for the volatile vault?
pool settings for in-memory sqlite to avoid the DB be wiped out
polvorin
approved these changes
Nov 30, 2023
|
closing it, replaced by #7003 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
fixes the creation of the software vault in NIF code by making sure that the in-memory database is shared by all special purpose vaults (signing, secure channels, etc...)
uses a random URL for the in-memory database and specify that the shared mode should be used to avoid the issue described here