Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: fix typo #169

Closed
wants to merge 1 commit into from
Closed

Conversation

winmillwill
Copy link
Contributor

This doc was a great read! This small typo jumped out at me and seems like an easy fix.

@mattgreg
Copy link
Sponsor Member

Thanks for submitting this PR!

We have a commit message format: https://www.ockam.io/learn/guides/contributions/CONTRIBUTING/#commit-messages

can you change the commit message to content: fix typo??

@winmillwill winmillwill changed the title small typo content: fix typo Jun 23, 2020
@winmillwill
Copy link
Contributor Author

Thanks for the pointer. Fixed!

@mattgreg
Copy link
Sponsor Member

recheckcla

@github-actions
Copy link

github-actions bot commented Jul 23, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@mattgreg
Copy link
Sponsor Member

Hey @winmillwill we have a brand new CLA workflow! Can you complete the CLA GitHub action instructions above?

@mattgreg mattgreg changed the base branch from production to develop July 23, 2020 14:52
@winmillwill
Copy link
Contributor Author

winmillwill commented Jul 23, 2020 via email

@mattgreg
Copy link
Sponsor Member

recheckcla

@mattgreg
Copy link
Sponsor Member

@winmillwill You are the first test user! You didn't know this little typo fix would be so impactful I bet.

From your post 2 hours ago we learned that a reply via email doesn't trigger the GitHub action. I've made a note of the issue.

Can you try again by opening your web browser and attempting to trigger the github action in a new comment?

❤️ 🙌

Also, DM me a mailing address and I'll send you one of our Ockam hats!

@winmillwill
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mattgreg
Copy link
Sponsor Member

That worked! Thanks for the persistence.

https://github.com/ockam-network/contributors/blob/master/cla-signers.json

@mattgreg mattgreg closed this Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants