Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhandled URI::InvalidURIError in Cleaner#clean_url #811

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Fix unhandled URI::InvalidURIError in Cleaner#clean_url #811

merged 2 commits into from
Jan 17, 2024

Commits on Jan 16, 2024

  1. Filter invalid URLs with query strings 

    As reported in #810, we don't handle invalid URLs in clean_url so raise
if the URL isn't valid

If the URL doesn't have a query string then it's not important that it
fails validation and so we can return it as-is

If the URL does have a query string and cannot be parsed, we can't
redact parameters individually and so redact the whole query string
instead — this way the URL could still be useful and we don't risk
leaking sensitive data
    @imjoehaines
    imjoehaines committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f102c73 View commit details
    Browse the repository at this point in the history

  2. Bump version

    @imjoehaines
    imjoehaines committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    32d8e4c View commit details
    Browse the repository at this point in the history