Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #805

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Fix CI #805

merged 6 commits into from
Dec 18, 2023

Conversation

imjoehaines
Copy link
Contributor

Goal

Several CI fixes:

  1. fix an incompatible dependency in the Rails 3 fixture that caused gem installation to fail
  2. speculative changes to the Que fixture — I'm still unsure of the actual problem here but the changes seem to have made it stable again 🤷‍♀️

I also noticed the automatic gem caching from the setup-ruby action wasn't working for the maze runner tests as they all used the same cache key and interfered with each other. They now have keys based on the fixture that's being run so the caching can work

@imjoehaines imjoehaines merged commit c14b1e3 into next Dec 18, 2023
133 checks passed
@imjoehaines imjoehaines deleted the fix-ci branch December 18, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjoehaines @tomlongridge