Release v6.25.0 #759
Merged
Release v6.25.0 #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concurrent-ruby v1.1.10 requires Ruby 2.2 to install
Fix concurrent-ruby version on Rubies < 2.2
Loosen Resque and Sidekiq version requirements in rails integrations fixture
Support was dropped for these versions in 5.16.0
Support was dropped for these versions in 2.3.0
3.0.0 requires Ruby 2.6+
Restrict minitest, connection_pool & rack-protection versions on older Rubies
Bundler _should_ always check dependency resolution with all optional groups, even when not actually installing them. However on old versions this check didn't happen, which is intuitive but wrong We were depending on the broken behaviour of older Bundler versions to get our tests to run on old Ruby versions. Instead, we should be upfront about these groups not installing on old Rubies by not defining them unless they will resolve This allows us to use more up-to-date Bundler versions on old Rubies
This is currently reported in a header, but the Event API prefers it to be in the request body. Supplying it in both is recommended by the docs: https://bugsnagerrorreportingapi.docs.apiary.io/#reference/0/notify/send-error-reports
Support running maze runner locally
Add 'payloadVersion' to report body
…-actions Move specs, linting & license auditing to GH Actions
Move Maze Runner tests to GH Actions
This returns true if: - name is a string with at least 1 character - variant is nil OR variant is a string
The FeatureFlagDelegate now ensures flags are valid before storing them, so we no longer deliver flags with invalid names
This allows users to add feature flags to Bugsnag whenever they interact
with their feature flag service, e.g.
```ruby
flag = get_flag_from_service('new-login-page')
if flag.enabled?
Bugsnag.add_feature_flag('new-login-page')
# render new login page
else
Bugsnag.clear_feature_flag('new-login-page')
# render old login page
end
```
The previous implementation relied on event's already being request
specific, but meant feature flags would usually have to be added in an
on_error callback
Now that the implementations of add_/clear_feature_flag(s) are the same, we can use a module to implement these methods and save us from having copy pasted methods/docs in 3 places
This embeds methods from included modules directly into the class' docs, rather than linking to them separately This makes the docs a lot clearer when a class includes some methods from a module as they are now listed next to every other method
Add support for feature flags
tomlongridge
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements
| #758
This PR also contains a lot of test changes, hence the massive diff