-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for feature flags #758
Merged
Merged
Commits on Nov 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fd37682 - Browse repository at this point
Copy the full SHA fd37682View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4ca5e0 - Browse repository at this point
Copy the full SHA e4ca5e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fcc5c8 - Browse repository at this point
Copy the full SHA 9fcc5c8View commit details -
This returns true if: - name is a string with at least 1 character - variant is nil OR variant is a string
Configuration menu - View commit details
-
Copy full SHA for 92c8950 - Browse repository at this point
Copy the full SHA 92c8950View commit details -
Drop feature flags that are invalid
The FeatureFlagDelegate now ensures flags are valid before storing them, so we no longer deliver flags with invalid names
Configuration menu - View commit details
-
Copy full SHA for 5e25613 - Browse repository at this point
Copy the full SHA 5e25613View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21b7edb - Browse repository at this point
Copy the full SHA 21b7edbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e2171a - Browse repository at this point
Copy the full SHA 0e2171aView commit details -
Configuration menu - View commit details
-
Copy full SHA for eca29f4 - Browse repository at this point
Copy the full SHA eca29f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c4506f - Browse repository at this point
Copy the full SHA 9c4506fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff88b6c - Browse repository at this point
Copy the full SHA ff88b6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 748f556 - Browse repository at this point
Copy the full SHA 748f556View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4562158 - Browse repository at this point
Copy the full SHA 4562158View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3901a48 - Browse repository at this point
Copy the full SHA 3901a48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33cc5e6 - Browse repository at this point
Copy the full SHA 33cc5e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9735247 - Browse repository at this point
Copy the full SHA 9735247View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6abf4ba - Browse repository at this point
Copy the full SHA 6abf4baView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1f416e - Browse repository at this point
Copy the full SHA f1f416eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ff633c - Browse repository at this point
Copy the full SHA 7ff633cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d32fe09 - Browse repository at this point
Copy the full SHA d32fe09View commit details -
Store feature flags per-request
This allows users to add feature flags to Bugsnag whenever they interact with their feature flag service, e.g. ```ruby flag = get_flag_from_service('new-login-page') if flag.enabled? Bugsnag.add_feature_flag('new-login-page') # render new login page else Bugsnag.clear_feature_flag('new-login-page') # render old login page end ``` The previous implementation relied on event's already being request specific, but meant feature flags would usually have to be added in an on_error callback
Configuration menu - View commit details
-
Copy full SHA for 7d943a8 - Browse repository at this point
Copy the full SHA 7d943a8View commit details -
Refactor feature flag methods into a new module
Now that the implementations of add_/clear_feature_flag(s) are the same, we can use a module to implement these methods and save us from having copy pasted methods/docs in 3 places
Configuration menu - View commit details
-
Copy full SHA for b18801e - Browse repository at this point
Copy the full SHA b18801eView commit details -
Enable YARD's 'embed-mixins' option
This embeds methods from included modules directly into the class' docs, rather than linking to them separately This makes the docs a lot clearer when a class includes some methods from a module as they are now listed next to every other method
Configuration menu - View commit details
-
Copy full SHA for 08b3be4 - Browse repository at this point
Copy the full SHA 08b3be4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92d2c5c - Browse repository at this point
Copy the full SHA 92d2c5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25784ea - Browse repository at this point
Copy the full SHA 25784eaView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.