Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "redacted keys" #703

Merged
merged 5 commits into from
Oct 5, 2021
Merged

Add support for "redacted keys" #703

merged 5 commits into from
Oct 5, 2021

Conversation

imjoehaines
Copy link
Contributor

Goal

This PR adds a new redacted_keys configuration option, which will replace meta_data_filters in the next major version

As well as being consistent with other notifier APIs, redacted_keys uses a case-insensitive, exact comparison. For example, the string abc will match abc and ABC but not abcd

This makes string matching more useful as it's less likely to hit a false positive, but the old behaviour is still possible by using a Regexp

lib/bugsnag/configuration.rb Show resolved Hide resolved
lib/bugsnag/configuration.rb Outdated Show resolved Hide resolved
spec/cleaner_spec.rb Outdated Show resolved Hide resolved
spec/cleaner_spec.rb Outdated Show resolved Hide resolved
spec/report_spec.rb Show resolved Hide resolved
@imjoehaines imjoehaines merged commit 6bc099f into next Oct 5, 2021
@imjoehaines imjoehaines deleted the add-redacted-keys branch October 5, 2021 14:21
@imjoehaines imjoehaines mentioned this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants