Add the stacktrace to Errors
#695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the stacktrace to
Errorinstances; this is the same stacktrace hash that theexceptionsarray uses (i.e. we're not duplicating it). This means the stacktrace can be modified on anErrorinstance and the changes will be reflected in the payload that's send to BugsnagDesign
To make the stacktrace readonly, I've made
Errora plain class instead of aStruct; I think this is better than messing around with the struct to get a readonly field (especially given the number of Rubies we support) and we don't really need most of the struct API anywayTesting
Had to tweak the existing tests as we can't directly compare Error instances without having identical stacktraces, which isn't really feasible