Add request to Report/Event
#693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently reads from metadata to avoid a breaking change, however this will be extracted from metadata as it's a top-level field in the API
kattrali
approved these changes
Sep 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR adds a new
requestattribute to the Report classCurrently this reads from metadata to preserve BC but, in the next major version, request data will be separated from metadata as it's a top-level field in the API (similar to app/device). Code that currently uses
metadata[:request]can be swapped to userequestto avoid breaking when this happensTesting
Added MR tests for current request fields in our Rails fixtures
Because it's not really possible/sensible to assert the exact values of certain fields in MR tests, I've also refactored the Rack spec to use a real
Reportinstance, instead of the mock it used previously